Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancel HttpError #2319

Merged
merged 3 commits into from
Jul 28, 2023
Merged

cancel HttpError #2319

merged 3 commits into from
Jul 28, 2023

Conversation

jdegoes
Copy link
Member

@jdegoes jdegoes commented Jul 27, 2023

No description provided.

@jdegoes jdegoes closed this Jul 27, 2023
@jdegoes jdegoes reopened this Jul 27, 2023
@jdegoes jdegoes closed this Jul 27, 2023
@jdegoes jdegoes reopened this Jul 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 89.33% and project coverage change: -0.13% ⚠️

Comparison is base (5dbcb2e) 63.68% compared to head (59ead11) 63.55%.
Report is 7 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2319      +/-   ##
==========================================
- Coverage   63.68%   63.55%   -0.13%     
==========================================
  Files         136      135       -1     
  Lines        7195     7203       +8     
  Branches     1261     1314      +53     
==========================================
- Hits         4582     4578       -4     
- Misses       2613     2625      +12
Files Changed Coverage Δ
zio-http/src/main/scala/zio/http/Response.scala 48.78% <ø> (+0.27%) ⬆️
zio-http/src/main/scala/zio/http/Handler.scala 64.01% <41.66%> (-0.89%) ⬇️
...a/zio/http/netty/server/ServerInboundHandler.scala 82.75% <66.66%> (+0.11%) ⬆️
...o-http/src/main/scala/zio/http/HandlerAspect.scala 70.79% <100.00%> (+0.59%) ⬆️
zio-http/src/main/scala/zio/http/Route.scala 72.00% <100.00%> (+1.41%) ⬆️
zio-http/src/main/scala/zio/http/Routes.scala 70.58% <100.00%> (ø)
zio-http/src/main/scala/zio/http/Status.scala 49.60% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegoes jdegoes closed this Jul 28, 2023
@jdegoes jdegoes reopened this Jul 28, 2023
@jdegoes jdegoes merged commit 3c2f8b0 into zio:main Jul 28, 2023
14 checks passed
@jdegoes jdegoes deleted the bye-bye-http-error branch July 28, 2023 09:58
987Nabil pushed a commit to 987Nabil/zio-http that referenced this pull request Jul 28, 2023
@jdegoes @987Nabil
cancel HttpError (zio#2319)
6c15296 
* cancel HttpError

* fixees
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigoo vigoo vigoo approved these changes

@amitksingh1490 amitksingh1490 Awaiting requested review from amitksingh1490

@adamgfraser adamgfraser Awaiting requested review from adamgfraser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdegoes @codecov-commenter @vigoo